Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apigee Organization Properties are Reset on Resource Update #10075

Closed
danistrebel opened this issue Sep 15, 2021 · 4 comments
Closed

Apigee Organization Properties are Reset on Resource Update #10075

danistrebel opened this issue Sep 15, 2021 · 4 comments
Assignees
Labels

Comments

@danistrebel
Copy link

danistrebel commented Sep 15, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.0.1
on darwin_amd64
+ provider registry.terraform.io/hashicorp/google v3.84.0

Affected Resource(s)

  • google_apigee_organization

Terraform Configuration Files

resource "google_apigee_organization" "org" {
  project_id = "my-apigee-org"
  analytics_region   = "europe-west1"
  runtime_type= "HYBRID"
}

Expected Behavior

Apigee hybrid org should respect the existing org properties at apply

Actual Behavior

Terraform apply removes non-default org properties.

From what I gathered so far:

Terraform provider mmv1 does not have the Apigee org properties defined that are set on the Apigee Org API resource e.g. :

"properties": {
    "property": [
      {
        "name": "features.hybrid.enabled",
        "value": "true"
      },
      {
        "name": "features.mart.connect.enabled",
        "value": "true"
      }
    ]
  }

as a TF resource property and therefore updates reset the properties on the organization. This currently removes the features.mart.connect.enabled property that is required for Apigee hybrid.

Steps to Reproduce

  1. create an Apigee hybrid org via API
  2. check the org property via: curl -H "Authorization: Bearer $TOKEN" -H "content-type:application/json" https://apigee.googleapis.com/v1/organizations/my-apigee-org and validate that the features.mart.connect.enabled property is set.
  3. tf import the existing Apigee org terraform import google_apigee_organization.org organizations/my-apigee-org
  4. make sure there are diffs that would require an org update
    1.terraform apply
  5. check the org property via: curl -H "Authorization: Bearer $TOKEN" -H "content-type:application/json" https://apigee.googleapis.com/v1/organizations/my-apigee-org and find that the features.mart.connect.enabled property is no longer set.
@pdallecarbonare
Copy link

This problem seems to affect only Apigee Org's created before version 1.4.x.

@edwardmedia edwardmedia self-assigned this Sep 15, 2021
@edwardmedia
Copy link
Contributor

@danistrebel that is a new field. Please file an enhancement to request it. closing the issue then

@danistrebel
Copy link
Author

@pdallecarbonare the issue also exists with 1.5 and 1.6 orgs.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants