Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Api Gateway in Serverless NEG #10729

Closed
cgrotz opened this issue Dec 10, 2021 · 3 comments
Closed

Support for Api Gateway in Serverless NEG #10729

cgrotz opened this issue Dec 10, 2021 · 3 comments

Comments

@cgrotz
Copy link

cgrotz commented Dec 10, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

At the moment Serverless NEGs can be configures with AppEngine, Cloud Functions and CloudRun. Api Gateway is also going to be supported in the future (https://cloud.google.com/api-gateway/docs/gateway-serverless-neg). The configuration approach for Api Gateway also seems to be more general compared to the current creation parameters.

It would be great if this could be added to the terraform resource for Serverless NEGs. Ideally reflecting the same more general approach that can be seen in gcloud sdk.

New or Affected Resource(s)

  • google_compute_region_network_endpoint_group

Potential Terraform Configuration

resource "google_compute_region_network_endpoint_group" "example_neg" {
  name                  = "example-neg"
  network_endpoint_type = "SERVERLESS"
  region                = "us-central1"
  serverless  {
    deployment-platform = "apigateway.googleapis.com"
    deployment-resource = "12345"
    deployment-url-mask = "..."
    deployment-version = "...unused by api gw..."
  }
}

References

@c2thorn c2thorn added the size/s label Dec 13, 2021
@c2thorn c2thorn added this to the Goals milestone Dec 13, 2021
@ivoilic
Copy link

ivoilic commented Dec 29, 2021

There is an open PR that implements this that requires further review/feedback:
GoogleCloudPlatform/magic-modules#5434
Here are some duplicate requests for this feature: #10476 #10061 #9907

@roaks3
Copy link
Collaborator

roaks3 commented Sep 28, 2022

Yep, that PR has been merged, and this is currently available in the beta provider. Thanks for linking the duplicates for us as well!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants