Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Api Gateway on google_compute_region_network_endpoint_group #9907

Closed
guibirow opened this issue Aug 25, 2021 · 2 comments
Closed

Support Api Gateway on google_compute_region_network_endpoint_group #9907

guibirow opened this issue Aug 25, 2021 · 2 comments

Comments

@guibirow
Copy link

guibirow commented Aug 25, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google has release the Api Gateway service to control access to resources like Cloud Functions, Cloud Run and AppEngine.
In order to setup custom domains, an External Https Load Balancer and a Serverless Network Endpoint Group need to be created, as described here.

To create the Serverless Network Endpoint Group, the docs suggest the following command:

//create a gateway GATEWAYNAME and then...

gcloud beta compute network-endpoint-groups create NEG_NAME \
   --region=europe-west2 \
   --network-endpoint-type=serverless \
   --serverless-deployment-platform=apigateway.googleapis.com \
   --serverless-deployment-resource=GATEWAYNAME

New or Affected Resource(s)

google_compute_region_network_endpoint_group

The Serverless Network Endpoint Group works exactly like the others used by functions and currently supported by the resource as follow:

resource "google_compute_region_network_endpoint_group" "function_neg" {
  name                  = "function-neg"
  network_endpoint_type = "SERVERLESS"
  region                = "us-central1"
  cloud_function {
    function = google_cloudfunctions_function.function_neg.name
  }
}

Potential Terraform Configuration

resource "google_compute_region_network_endpoint_group" "gateway_neg" {
  name                  = "gateway-neg"
  network_endpoint_type = "SERVERLESS"
  region                = "europe-west2"
  api_gateway {
    gateway = "GATEWAYID"
  }
}

or using serverless_deployment to match the new rest api definition

resource "google_compute_region_network_endpoint_group" "gateway_neg" {
  name                  = "gateway-neg"
  network_endpoint_type = "SERVERLESS"
  region                = "europe-west2"
  serverless_deployment {
    "platform": "apigateway.googleapis.com",
    "resource": "GATEWAYID"
  }
}

References

@roaks3
Copy link
Collaborator

roaks3 commented Sep 28, 2022

Per #10729, this is now implemented in the beta provider.

@roaks3 roaks3 closed this as completed Sep 28, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants