Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DenyMaintenancePeriod for CloudSQL Instance #11287

Comments

@mustafakirimli
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

CloudSQL has deny maintenance option for given time window (90 days max) to postpone upcoming maintenance requests if you are in a sale/peak season etc and do not wanna get distracted by maintenance.

I just would like to know this feature intentionally ignored because of some challenge etc or just missed,

Note: documents/rest api says denyMaintenancePeriods takes array but when you try to set multiple date ranges it throws error. Maybe that is added for f(u)eature.

New or Affected Resource(s)

  • google_sql_database_instance

Potential Terraform Configuration

# max 90 days
deny_maintenance_window {
  start {
    year = "0" # 0 means recurring yearly
    month = "12"
    day = "25"
    hour = "00:00:00"
 },
 end {
    year = "0"
    month = "1"
    day = "5"
    hour = "00:00:00"
  }
}

References

https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances#DenyMaintenancePeriod
https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances#DatabaseInstance
https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances/patch

@rileykarson rileykarson added this to the Goals milestone Mar 21, 2022
c2thorn pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Nov 22, 2022
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Nov 22, 2022
Fixes hashicorp/terraform-provider-google#11287

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Nov 22, 2022
Fixes hashicorp#11287

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Nov 22, 2022
Fixes hashicorp/terraform-provider-google#11287

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Nov 22, 2022
Fixes #11287

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-validator that referenced this issue Nov 22, 2022
Fixes hashicorp/terraform-provider-google#11287

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this issue Nov 22, 2022
Fixes hashicorp/terraform-provider-google#11287

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.