Add GKE logging variant field for increasing log agent throughput #12667

Dev25 · 2022-09-28T13:55:39Z

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

GKE has recently added support for configuring a high throughput logging mode at both a cluster and node pool level. Add this field so users can opt in to the MAX_THROUGHPUT mode.

https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#throughput

New or Affected Resource(s)

google_container_cluster
google_container_node_pool

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_container_cluster" "primary" {
  name               = "demo-cluster"

  logging_variant = "MAX_THROUGHPUT"
  # or
  logging_config {
    variant = "MAX_THROUGHPUT"
  }
}

resource "google_container_node_pool" "pools" {
  node_config {
     logging_config {
         variant = "MAX_THROUGHPUT"
     }
  }
}

References

The text was updated successfully, but these errors were encountered:

giuliano-sider · 2022-10-19T20:20:21Z

I think this issue is important for GKE users and I'm working on a PR to add the field to google_container_cluster. Subsequently, I can submit a PR for the google_container_node_pool as well. I was thinking of adding logging_variant inside the node_pool_defaults to stay more or less consistent with the GKE API itself, and to emphasize that this is a cluster-level value that is applied to node pools by default; that is, it's the logging variant that's used throughout the cluster unless overridden at the node pool level. For example, by specifying

resource "google_container_cluster" "with_logging_variant_node_pool_default" {
  name               = "foo-cluster"
  location           = "us-central1-f"
  initial_node_count = 1

  node_pool_defaults {
    node_config_defaults {
      logging_variant = "MAX_THROUGHPUT"
    }
  }
}

every node pool in the cluster will have the max throughput logging agent configured (see the GKE docs for more information).

… clusters. This PR partly implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-level default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "foo-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every node pool in the cluster will have the max throughput logging agent configured (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). A follow-up PR should add the ability to override the value at the node pool level as well: ```terraform resource "google_container_node_pool" "with_logging_variant" { name = "foo-node-pool" node_config { logging_config { variant = "MAX_THROUGHPUT" } } } ```

… clusters. This PR partly implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-level default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every node pool in the cluster will have the max throughput logging agent configured by default (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information).

…node pool. This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding this field, GKE users will be able to select a logging variant at the node pool level as well as the cluster level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool" cluster = google_container_cluster.with_logging_variant_node_pool_default node_config { logging_config = "MAX_THROUGHPUT" } } node pools in the cluster (e.g. the default node pool) will have the default logging agent configured (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but the specified node pool will have the max throughput agent.

… clusters. This PR partly implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-level default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every node pool in the cluster will have the max throughput logging agent configured by default (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information).

…node pool. This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding this field, GKE users will be able to select a logging variant at the node pool level as well as the cluster level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } node pools in the cluster (e.g. the default node pool) will have the default logging agent configured (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but the specified node pool will have the max throughput agent.

… clusters. This PR partly implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-level default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every node pool in the cluster will have the max throughput logging agent configured by default (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information).

…node pool. This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding this field, GKE users will be able to select a logging variant at the node pool level as well as the cluster level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } node pools in the cluster (e.g. the default node pool) will have the default logging agent configured (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but the specified node pool will have the max throughput agent.

… clusters. This PR partly implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-level default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every node pool in the cluster will have the max throughput logging agent configured by default (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). Add a `logging_variant` field to select the logging variant of a GKE node pool. This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding this field, GKE users will be able to select a logging variant at the node pool level as well as the cluster level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } node pools in the cluster (e.g. the default node pool) will have the default logging agent configured (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but the specified node pool will have the max throughput agent.

…ults for GKE clusters. This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent.

…ults for GKE clusters. (#6744) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent.

…ults for GKE clusters. (hashicorp#6744) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (hashicorp#6744) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput hashicorp#12667](hashicorp#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (#6744) (#4889) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (#6744) (#13049) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (#6744) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (#6744) (#1126) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent. Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>

…ults for GKE clusters. (GoogleCloudPlatform#6744) This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput #12667](hashicorp/terraform-provider-google#12667). By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "MAX_THROUGHPUT" } } } ``` every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information). GKE users will also be able to select a logging variant at the node pool level. For example, by specifying ```terraform resource "google_container_cluster" "with_logging_variant_node_pool_default" { name = "example-cluster" location = "us-central1-f" initial_node_count = 1 node_pool_defaults { node_config_defaults { logging_variant = "DEFAULT" } } } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-0" cluster = google_container_cluster.with_logging_variant_node_pool_default.name } resource "google_container_node_pool" "with_high_throughput_logging_variant" { name = "example-node-pool-1" cluster = google_container_cluster.with_logging_variant_node_pool_default.name node_config { logging_variant = "MAX_THROUGHPUT" } } ``` example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent.

github-actions · 2022-12-16T02:11:55Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Dev25 added the enhancement label Sep 28, 2022

rileykarson added size/s service/container labels Oct 3, 2022

rileykarson added this to the Goals milestone Oct 3, 2022

giuliano-sider mentioned this issue Oct 26, 2022

Add fields for specifying GKE logging variant at the cluster-wide and node pool level. GoogleCloudPlatform/magic-modules#6744

Merged

5 tasks

melinath closed this as completed in GoogleCloudPlatform/magic-modules#6744 Nov 16, 2022

This was referenced Nov 16, 2022

Add fields for specifying GKE logging variant at the cluster-wide and node pool level. hashicorp/terraform-provider-google-beta#4889

Merged

Add fields for specifying GKE logging variant at the cluster-wide and node pool level. #13049

Merged

modular-magician mentioned this issue Nov 16, 2022

Add fields for specifying GKE logging variant at the cluster-wide and node pool level. GoogleCloudPlatform/terraform-validator#1126

Merged

5 tasks

github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GKE logging variant field for increasing log agent throughput #12667

Add GKE logging variant field for increasing log agent throughput #12667

Dev25 commented Sep 28, 2022

giuliano-sider commented Oct 19, 2022

github-actions bot commented Dec 16, 2022

Add GKE logging variant field for increasing log agent throughput #12667

Add GKE logging variant field for increasing log agent throughput #12667

Comments

Dev25 commented Sep 28, 2022

Community Note

Description

New or Affected Resource(s)

Potential Terraform Configuration

References

giuliano-sider commented Oct 19, 2022

github-actions bot commented Dec 16, 2022