Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cloud Tasks Queue TombstoneTtl parameter #12719

Open
kovalevvlad opened this issue Oct 5, 2022 · 2 comments
Open

Add support for Cloud Tasks Queue TombstoneTtl parameter #12719

kovalevvlad opened this issue Oct 5, 2022 · 2 comments

Comments

@kovalevvlad
Copy link

kovalevvlad commented Oct 5, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google Cloud Tasks queues support the TombstoneTtl parameter (https://cloud.google.com/tasks/docs/reference/rest/v2beta3/projects.locations.queues) which controls how soon a task with the same unique ID can be re-added to the queue. When using deduplication this parameter is pretty important. By default, the parameter is set to one hour hence deduplication prevents tasks with the same ID from being re-added to the queue for an hour. This is quite prohibitive and makes this feature significantly less useful.

New or Affected Resource(s)

  • google_cloud_tasks_queue

Potential Terraform Configuration

Proposed config format:

resource "google_cloud_tasks_queue" "async_task_queue" {
    ...
    tombstone_ttl = "3s"
    ...
}
@rileykarson rileykarson added this to the Goals milestone Oct 10, 2022
@melinath
Copy link
Collaborator

b/253294293

@AlfatahB
Copy link
Contributor

AlfatahB commented Nov 2, 2022

Currently, Terraform Provider Beta is using GA API for cloudtasks product. As we want to add support for tombstone_ttl field which is a beta-only field, we need to use Beta API. But, Beta API doesn't have appEngineRoutingOverride field which is available in GA API. Instead, the appEngineRoutingOverride field is inside of the appEngineHttpQueue field. I guess this might require schema changes (particularly for cloud_tasks_queue beta resource) that will be a breaking change.

CC: @melinath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants