Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash sums to google_storage_bucket_object_content #13002

Open
glerchundi opened this issue Nov 10, 2022 · 0 comments 路 May be fixed by GoogleCloudPlatform/magic-modules#6895
Open

Add hash sums to google_storage_bucket_object_content #13002

glerchundi opened this issue Nov 10, 2022 · 0 comments 路 May be fixed by GoogleCloudPlatform/magic-modules#6895

Comments

@glerchundi
Copy link

glerchundi commented Nov 10, 2022

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In order to add source_code_hash parameters in some of the providers that accept package contents like AWS Lambda or Fastly Compute@Edge, I propose expose file hash sums to directly pipe into the external provider services.

New or Affected Resource(s)

  • google_storage_bucket_object_content

Potential Terraform Configuration

This is I would like to do:

data "google_storage_bucket_object_content" "this" {
  name   = "component/package.tar.gz"
  bucket = "my-fastly-repository"
}

resource "fastly_service_compute" "service_compute" {
  name = "Service compute"
  package {
    content_base64    = data.google_storage_bucket_object_content.this.content_base64
    source_code_hash = google_storage_bucket_object_content.this.output_sha512
  }
}

Other PRs

References

b/275608337

glerchundi added a commit to glerchundi/magic-modules that referenced this issue Nov 30, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Nov 30, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Nov 30, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Dec 3, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Dec 3, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Dec 3, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
glerchundi added a commit to glerchundi/magic-modules that referenced this issue Dec 3, 2022
This returns the same content present in the return object but exposed
by using Base64 encoding. This is mostly useful for reading binary
content.

Our particular use case is to push the content of a WASM file to a
Fastly Compute@Edge service. But this is also useful for other
serverless services like AWS Lambda as well.

This alongside including the hash sums for the source object content
proposed in
hashicorp/terraform-provider-google#13002,
would allow us pushing content directly from Google Storage Object
Content data source to Fastly Compute@Edge. AWS Lambda also uses the
same version/content discrimination method of sending the content hash
sum within the `source_code_hash` parameter.

Sign-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
@rileykarson rileykarson added this to the Backlog milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants