Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_node_pool: enabling resource labels #13064

Comments

@sakuya9t
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Allow modification of resource labels on google_container_node_pool through node config

New or Affected Resource(s)

  • google_container_node_pool

Potential Terraform Configuration

resource "google_container_node_pool" "np_with_node_config" {
  name               = "test-nodepool"
  location           = "us-central1-a"
  cluster            = "test-cluster"
  initial_node_count = 1
  node_config {
    machine_type = "g1-small"
    min_cpu_platform = "Intel Broadwell"
    resource_labels = {
      "key1" = "value1"
      "key2" = "value2"
    }
@sakuya9t
Copy link
Contributor Author

Created pull request here

modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Nov 22, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Nov 22, 2022
…ashicorp#6842)

Fixes hashicorp#13064

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Nov 22, 2022
…6842) (#4913)

Fixes hashicorp/terraform-provider-google#13064

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Nov 22, 2022
…6842) (#13104)

Fixes #13064

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-validator that referenced this issue Nov 22, 2022
…6842)

Fixes hashicorp/terraform-provider-google#13064

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this issue Nov 22, 2022
…6842) (#1144)

Fixes hashicorp/terraform-provider-google#13064

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.