Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metric_descriptor argument optional and computer for resource_logging_metric #13215

Closed
LucaPrete opened this issue Dec 10, 2022 · 2 comments
Labels
Milestone

Comments

@LucaPrete
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Make metric_descriptor argument optional and computer for resource_logging_metric.
If not specified the field is automatically populated from Google APIs.

Affected Resource(s)

  • google_logging_metric

Potential Terraform Configuration

Need to:

  • remove required: false in logging api.yaml
  • add default_from_apis: true in terraform.yaml
  • remove metric_descriptor where not needed in tests

References

@melinath melinath added this to the Goals milestone Dec 12, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 12, 2022
…_logging_metric (hashicorp#6937)

Co-authored-by: Luca Prete <lucaprete@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Dec 12, 2022
…metric (#6937) (#13225)

Co-authored-by: Luca Prete <lucaprete@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Luca Prete <lucaprete@google.com>
@github-actions github-actions bot added service/logging forward/review In review; remove label to forward labels Aug 17, 2023
@roaks3
Copy link
Collaborator

roaks3 commented Sep 28, 2023

This appears to have been fixed by GoogleCloudPlatform/magic-modules#6937

@roaks3 roaks3 closed this as completed Sep 28, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants