Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify google_storage_transfer_job resource to add credentials_secret field for azure_blob_storage_data_source block #16263

Comments

@kumailkermalli-datatonic
Copy link

kumailkermalli-datatonic commented Oct 16, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add the optional field credentials_secret to the azure_blob_storage_data_source block in google_storage_transfer_job

Context:

The Microsoft Azure Storage source for the Cloud Storage Transfer Job now supports (public preview) a SAS token being referenced in secret manager through a credentials_secret field. The credentials_secret field accepts a reference to a secret manager resource name. Previously SAS tokens had to be specified directly in Terraform config through the azure_credentials_block.

This additional field would be useful as it provides the option to store tokens outside of Terraform and thus not in state. The additional field would need to be added in the beta provider only, since it is in preview

New or Affected Resource(s)

Affected Resource:

  • google_storage_transfer_job

Potential Terraform Configuration

resource "google_storage_transfer_job" "example-transfer" {
  description = "Example Transfer"
  project     = example_project_id

  transfer_spec {
    transfer_options {
      delete_objects_unique_in_sink = false
    }
    azure_blob_storage_data_source {
      storage_account = "foo"
      container       = "bar"
      path            = ""
      credentials_secret = "projects/var.project_number/secrets/var.secret_name" // new field
      }
    }
    gcs_data_sink {
      bucket_name = "example-bucket-foo"
      path        = "foo/bar/"
    }
  }
}

References

b/306619208

@kumailkermalli-datatonic
Copy link
Author

Happy to raise a PR to add this in

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.