Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose service ipv4 cidr as attribute #3770

Closed
fprimex opened this issue Jun 3, 2019 · 3 comments
Closed

Expose service ipv4 cidr as attribute #3770

fprimex opened this issue Jun 3, 2019 · 3 comments
Assignees

Comments

@fprimex
Copy link

fprimex commented Jun 3, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Please expose the service ipv4 cidr block for the google_container_cluster resource. It appears to be in the SDK:

https://github.com/googleapis/google-cloud-go/blob/master/container/container.go#L135-L138

This attribute differs from the value in ip_allocation_policy, and can be viewed with gcloud container clusters describe <cluster-name>.

New or Affected Resource(s)

  • google_cluster_container

Potential Terraform Configuration

resource "google_container_cluster" "primary" {
...
}

# Elsewhere

   google_container_cluster.primary.service_ipv4_cidr

References

@ghost ghost added the enhancement label Jun 3, 2019
paddycarver added a commit that referenced this issue Jun 3, 2019
There's a computed, output-only services_ipv4_cidr attribute for
GKE Clusters that we're currently not populating. This PR adds support
for them. See #3770.
@paddycarver
Copy link
Contributor

This was merged as GoogleCloudPlatform/magic-modules#1873. It should be part of our next release.

@rileykarson
Copy link
Collaborator

Closing this out as it was released.

@ghost
Copy link

ghost commented Jul 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants