Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for google_kms_crypto_key_iam_policy #4163

Closed
maroux opened this issue Aug 5, 2019 · 3 comments
Closed

Add support for google_kms_crypto_key_iam_policy #4163

maroux opened this issue Aug 5, 2019 · 3 comments

Comments

@maroux
Copy link
Contributor

maroux commented Aug 5, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

IAM keys can be managed by non-authoritative member resource, or authoritative-for-a-role binding resource, however the policy resource seems to be missing for KMS Crypto Keys. This just seems like an oversight in #781 (or perhaps IAM didn't support it at the time?).

New or Affected Resource(s)

  • google_kms_crypto_key_iam_policy

Potential Terraform Configuration

data "google_iam_policy" "key_policy" {
  binding {
    members = ["user:"]

    role = "roles/cloudkms.cryptoKeyDecrypter"
  }
}

resource "google_kms_crypto_key_iam_policy" "key_policy" {
  crypto_key_id = "${google_kms_crypto_key.key.id}"
  policy_data   = "${data.google_iam_policy.key_policy.policy_data}"
}

References

https://github.com/terraform-providers/terraform-provider-google/pulls/781
#762

@ghost ghost added the enhancement label Aug 5, 2019
maroux added a commit to maroux/terraform-provider-google that referenced this issue Aug 5, 2019
maroux added a commit to maroux/terraform-provider-google that referenced this issue Aug 5, 2019
@wmuizelaar
Copy link

Any update on this? Waiting for the PR here ;-)

@paddycarver paddycarver added this to the Near-Term Goals milestone Dec 6, 2019
maroux added a commit to maroux/terraform-provider-google that referenced this issue Dec 18, 2019
@danawillow
Copy link
Contributor

@ghost
Copy link

ghost commented Feb 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants