Add support for management settings in google_container_cluster NAP

[davidquarles]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It would be amazing if the provider supported the v1 upstream NAP NodeManagement fields. For our use case, I'm not super comfy turning on node autoprovisioning in production without node-autorepair.

New or Affected Resource(s)

• google_container_cluster

Potential Terraform Configuration

resource "google_container_cluster" "foo" {
  name = "foo"
  # ...
  cluster_autoscaling {
    auto_provisioning_defaults {
      service_account = google_service_account.cluster_nodes_service_account.email

      # new field, mirroring google_container_node_pool.management structure
      management {
        auto_repair = true
        auto_upgrade = true
      }
    }
  }
}

References

• Add support for auto-{upgrade,healing} in google_container_node_pool #655
• Add support for google_container_node_pool management #669

[davidquarles]

I contributed the linked PR for this functionality at the google_container_node_pool layer back when (and very much appreciated the community vibe over here!) and I'm happy to contribute here as well, assuming it's not a wild amount of additional complexity to do so.

[danawillow]

That would be great! I'll assign this issue to you. I imagine it'll be quite similar to the other one.

[mitj04]

This issue is to add support for management in the google_container_cluster NAP. But, this has already been added as part of this PR which was part of this issue. Closing this issue, please reach out to us in case of any queries.

We can close this PR as well which was resolving this issue.

[mitj04]

b/263545635

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.