Adding 'management' attribute to the google_container_cluster resource #6794

mitj04 · 2022-11-08T12:40:01Z

Part of this hashicorp/terraform-provider-google#9180

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: Adding management attribute to the google_container_cluster resource

modular-magician · 2022-11-08T12:41:03Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-11-08T12:54:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 175 insertions(+))
Terraform Beta: Diff ( 3 files changed, 175 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-08T13:42:00Z

Tests analytics

Total tests: 2226
Passed tests 1977
Skipped tests: 240
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb

modular-magician · 2022-11-08T13:58:52Z

Tests passed during RECORDING mode:
TestAccContainerCluster_nodeAutoprovisioningDefaults[Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement[Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Debug log]

All tests passed
View the build log or the debug log for each test

megan07

A few small comments, but otherwise looks good. Thanks!

megan07 · 2022-11-08T18:06:03Z

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

+															"auto_upgrade_start_time": {
+																Type:        schema.TypeString,
+																Computed:    true,
+																Description: `his field is set when upgrades are about to commence with the approximate start time for the upgrades, in RFC3339 text format.`,


nit:

Suggested change

Description: `his field is set when upgrades are about to commence with the approximate start time for the upgrades, in RFC3339 text format.`,

Description: `This field is set when upgrades are about to commence with the approximate start time for the upgrades, in RFC3339 text format.`,

megan07 · 2022-11-08T18:06:27Z

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

+												},
+												"upgrade_options": {
+													Type:        schema.TypeList,
+													Optional:    true,


Looks like the two nested fields are both output only, so this block should be Computed only.

megan07 · 2022-11-08T18:07:09Z

mmv1/third_party/terraform/resources/resource_container_cluster.go.erb

@@ -3890,6 +3933,7 @@ func expandAutoProvisioningDefaults(configured interface{}, d *schema.ResourceDa
 		ImageType:      	config["image_type"].(string),
 		BootDiskKmsKey: 	config["boot_disk_kms_key"].(string),
 		UpgradeSettings:	expandUpgradeSettings(config["upgrade_settings"]),
+		Management:         expandManagement(config["management"]),


nit: would you mind aligning this line to the ones above it?

megan07 · 2022-11-08T18:09:41Z

mmv1/third_party/terraform/tests/resource_container_cluster_test.go.erb

+
+	resource_limits {
+	  resource_type = "cpu"
+      maximum       = 2


nit: would you align this line as well please?

…odules into mj_gke_management_attr_189224778

modular-magician · 2022-11-09T06:13:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 174 insertions(+))
Terraform Beta: Diff ( 3 files changed, 174 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-09T06:57:11Z

Tests analytics

Total tests: 2233
Passed tests 1991
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-11-09T06:57:33Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

megan07

Looks good! Thanks!

GoogleCloudPlatform#6794) * Adding 'management' attribute to the google_container_cluster resource * Addressing minor review comments * Fixing typo * Removing unintended spaces

Adding 'management' attribute to the google_container_cluster resource

225abbf

modular-magician requested a review from megan07 November 8, 2022 12:41

mitj04 marked this pull request as ready for review November 8, 2022 12:42

megan07 suggested changes Nov 8, 2022

View reviewed changes

mitj04 added 2 commits November 9, 2022 05:33

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

da6d24d

…odules into mj_gke_management_attr_189224778

Addressing minor review comments

fb5219a

modular-magician requested a review from megan07 November 9, 2022 05:54

mitj04 and others added 2 commits November 9, 2022 05:55

Fixing typo

e6515ea

Removing unintended spaces

520ff08

megan07 approved these changes Nov 9, 2022

View reviewed changes

megan07 merged commit 3be660e into GoogleCloudPlatform:main Nov 9, 2022

mitj04 mentioned this pull request Dec 8, 2022

Add support for the rest of the AutoprovisioningNodePoolDefaults settings in google_container_cluster hashicorp/terraform-provider-google#9180

Closed

mitj04 mentioned this pull request Dec 23, 2022

Add support for management settings in google_container_cluster NAP hashicorp/terraform-provider-google#5579

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding 'management' attribute to the google_container_cluster resource #6794

Adding 'management' attribute to the google_container_cluster resource #6794

mitj04 commented Nov 8, 2022 •

edited

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

megan07 left a comment

megan07 Nov 8, 2022

mitj04 Nov 9, 2022

megan07 Nov 8, 2022

mitj04 Nov 9, 2022

megan07 Nov 8, 2022

mitj04 Nov 9, 2022

megan07 Nov 8, 2022

mitj04 Nov 9, 2022

modular-magician commented Nov 9, 2022

modular-magician commented Nov 9, 2022

modular-magician commented Nov 9, 2022

megan07 left a comment

	Description: `his field is set when upgrades are about to commence with the approximate start time for the upgrades, in RFC3339 text format.`,
	Description: `This field is set when upgrades are about to commence with the approximate start time for the upgrades, in RFC3339 text format.`,

Adding 'management' attribute to the google_container_cluster resource #6794

Adding 'management' attribute to the google_container_cluster resource #6794

Conversation

mitj04 commented Nov 8, 2022 • edited

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

Diff report

modular-magician commented Nov 8, 2022

Tests analytics

Action taken

modular-magician commented Nov 8, 2022

megan07 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Nov 9, 2022

Diff report

modular-magician commented Nov 9, 2022

Tests analytics

Action taken

modular-magician commented Nov 9, 2022

megan07 left a comment

Choose a reason for hiding this comment

mitj04 commented Nov 8, 2022 •

edited