Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Data Transfer Config: Add Integer Partitioning Support #6588

Open
kurtmaile opened this issue Jun 15, 2020 · 2 comments
Open

BigQuery Data Transfer Config: Add Integer Partitioning Support #6588

kurtmaile opened this issue Jun 15, 2020 · 2 comments

Comments

@kurtmaile
Copy link

kurtmaile commented Jun 15, 2020

Description

google_bigquery_data_transfer_config to support integer partitioning which is GA.

Seems this resource is generally getting left behind a bit of late, there are 4 outstanding issues on it, will it be given some priority? Realise the team will be busy on many things, but it is starting to force us to look away from TF on GCP.

New or Affected Resource(s)

  • google_bigquery_data_transfer_config

Potential Terraform Configuration

resource "google_bigquery_data_transfer_config" "tc"  {

  display_name = "xxx"
  location = "EU"
  data_source_id = "scheduled_query"
  schedule = "xxxx"
  destination_dataset_id = "ds"
  params = {
    destination_table_name_template = "dt"
    write_disposition = "WRITE_TRUNCATE"
    query = "SELECT * FROM `v`"
    partitioning_field = "anInt"
    range_partitioning=customer_id,0,100,10
  }
}

This matches the 4 fields required for int bucket based partitioning.

References

https://cloud.google.com/bigquery/docs/creating-integer-range-partitions#integer_range_partitioning_with_clustering

b/284524817

@ghost ghost added the enhancement label Jun 15, 2020
@danawillow
Copy link
Contributor

Hey @kurtmaile, I don't see anything in the REST API for transfer configs (https://cloud.google.com/bigquery-transfer/docs/reference/datatransfer/rest/v1/projects.locations.transferConfigs) that mentions range partitioning, though it's possible that it's supported via the params map, like in your potential config. That block is just a key/value map, so you could try putting those fields in there to see if it works. What happens if you try it?

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Nov 7, 2022
…pe (hashicorp#6588)

* fix: added parameter region to google_vertex_ai_featurestore_entitytype

* Revert "fix: added parameter region to google_vertex_ai_featurestore_entitytype"

This reverts commit ddf67919b021469c9f3e4593426bfedd127cd6fb.

* fix: extract region from the featurestore id

* fix: add custom_import for the region field

* fix: 2nd attempt to fix the custom_import override

* fix: 3rd attempt to fix the custom_import for the region field

* fix: 4th attempt to fix the custom_import for the region field

* fix: reverted the custom_import back

* fix: use the right import code for the custom_import

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Nov 7, 2022
…pe (#6588) (#12959)

* fix: added parameter region to google_vertex_ai_featurestore_entitytype

* Revert "fix: added parameter region to google_vertex_ai_featurestore_entitytype"

This reverts commit ddf67919b021469c9f3e4593426bfedd127cd6fb.

* fix: extract region from the featurestore id

* fix: add custom_import for the region field

* fix: 2nd attempt to fix the custom_import override

* fix: 3rd attempt to fix the custom_import for the region field

* fix: 4th attempt to fix the custom_import for the region field

* fix: reverted the custom_import back

* fix: use the right import code for the custom_import

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@melinath
Copy link
Collaborator

melinath commented May 26, 2023

If @danawillow's suggestion doesn't work, this could be something to look into adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants