Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source "google_compute_managed_ssl_certificate" is missing #6637

Open
JoshuaEdwards1991 opened this issue Jun 18, 2020 · 2 comments
Open

Comments

@JoshuaEdwards1991
Copy link

JoshuaEdwards1991 commented Jun 18, 2020

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Data source for google_compute_managed_ssl_certificate missing

New or Affected Resource(s)

  • google_compute_managed_ssl_certificate

Potential Terraform Configuration

data "google_compute_managed_ssl_certificate" "cert" {
  provider = google-beta

  name    = var.name
  project = var.project
}

References

  • #0000

b/305377553

@ghost ghost added the enhancement label Jun 18, 2020
@danawillow danawillow added this to the Goals milestone Jun 22, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Oct 12, 2022
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Oct 12, 2022
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@AlfatahB
Copy link
Contributor

b/263774833

@AlfatahB
Copy link
Contributor

I've looked into this issue and it seems we need to add support for google_compute_managed_ssl_certificate datasource.

  • Product Name: Compute Engine
  • New Datasource Name: google_compute_managed_ssl_certificate
  • API Docs: Managed SSL Certificates
  • Notes:
    • REST API Endpoint: GET - https://compute.googleapis.com/compute/v1/projects/{project}/global/sslCertificates/{resourceId}
    • The {resourceId} in the GET API refers to the name of the SslCertificate resource.
    • It seems that this datasource can be supported using the Read function of the resource.
    • This can be handled using the datasourceSchemaFromResourceSchema, addRequiredFieldsToSchema and addOptionalFieldsToSchema functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants