Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting a wildcard capability so we don't have to explicitly add new services as they become available to google_access_context_manager_service_perimeter #6680

Open
anubbhavm opened this issue Jun 24, 2020 · 1 comment

Comments

@anubbhavm
Copy link

anubbhavm commented Jun 24, 2020

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Request to implement a wildcard capability so we don't have to explicitly add new services as they become available. GCP regularly updates the list of restricted services, so this gives the customer an option to avoid appending to the list of restricted services.

New or Affected Resource(s)

  • google_access_context_manager_service_perimeter

Potential Terraform Configuration

resource "google_access_context_manager_service_perimeter" "service-perimeter" {
  parent = "accessPolicies/${google_access_context_manager_access_policy.access-policy.name}"
  name   = "accessPolicies/${google_access_context_manager_access_policy.access-policy.name}/servicePerimeters/perimeter1"
  title  = "new perimeter"

  # The asterisk suggests all the supported services will be restricted.
  status {
    restricted_services = ["*.googleapis.com"]
  }
}
@ghost ghost added the enhancement label Jun 24, 2020
@danawillow
Copy link
Contributor

This seems more like a feature request for the API itself, rather than for Terraform. If the API supports it then Terraform can do it already, but if not, you should make a request there.

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Nov 8, 2022
* BigQuery: Added support for authorized routine

* BigQuery: Added examples for authorized routine

* Update mmv1/products/bigquery/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/bigquery_dataset_authorized_routine.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add legacy iam access to test case

* remove legacy roles

* correct variable names and values

* replace - to _

* [wip]added hand written test

* fix corrupted test

* Update mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Nov 8, 2022
* BigQuery: Added support for authorized routine

* BigQuery: Added examples for authorized routine

* Update mmv1/products/bigquery/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/bigquery_dataset_authorized_routine.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add legacy iam access to test case

* remove legacy roles

* correct variable names and values

* replace - to _

* [wip]added hand written test

* fix corrupted test

* Update mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
megan07 added a commit that referenced this issue Nov 11, 2022
megan07 added a commit that referenced this issue Nov 11, 2022
@github-actions github-actions bot added service/accesscontextmanager forward/review In review; remove label to forward labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants