Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IAM authentication to google_sql_user #7512

Closed
shanesavoie opened this issue Oct 13, 2020 · 4 comments
Closed

Add support for IAM authentication to google_sql_user #7512

shanesavoie opened this issue Oct 13, 2020 · 4 comments

Comments

@shanesavoie
Copy link

shanesavoie commented Oct 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

This is a preview feature, but would love support for this in the future.

https://cloud.google.com/sql/docs/postgres/create-manage-iam-users?authuser=1#gcloud

It looks like there's a new flag --type=cloud_iam_user|cloud_iam_service_account used to specify between a normal user and IAM authenticated user.

New or Affected Resource(s)

  • google_sql_user

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_sql_user" "user" {
  ...
  type="cloud_iam_user"
}

References

  • #0000
@ghost ghost added the enhancement label Oct 13, 2020
@rileykarson rileykarson added this to the Goals milestone Oct 19, 2020
@dabbertorres
Copy link
Contributor

dabbertorres commented Dec 11, 2020

I'd be happy to take a crack at adding this feature (over in magic-modules?), unless of course someone is already working on it.

Any objections/concerns?

@rileykarson
Copy link
Collaborator

@dabbertorres: Nobody is that I'm aware! You could edit in Magic Modules (there's a handwritten file @ https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/resources/resource_sql_user.go) but sending a PR in this repo is fine. One of us will upstream it to MM.

slevenick pushed a commit that referenced this issue Dec 17, 2020
* add support for IAM authentication to google_sql_user for #7512

* Add documentation for cloud_sql_user.type field
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 17, 2020
 (hashicorp#4322)

* add support for IAM authentication to google_sql_user for hashicorp#7512

* Add documentation for cloud_sql_user.type field

Co-authored-by: Alec Iverson <alec@myndshft.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Dec 17, 2020
… (#8047)

* add support for IAM authentication to google_sql_user for #7512

* Add documentation for cloud_sql_user.type field

Co-authored-by: Alec Iverson <alec@myndshft.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Alec Iverson <alec@myndshft.com>
@rileykarson
Copy link
Collaborator

Looks like the change downstream was missing a Fixes:. Closing.

@ghost
Copy link

ghost commented Feb 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants