Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: support alpha/beta compute APIs in addition to GA #93

Closed
hashibot opened this issue Jun 13, 2017 · 4 comments
Closed
Assignees

Comments

@hashibot
Copy link

This issue was originally opened by @danawillow as hashicorp/terraform#14742. It was migrated here as part of the provider split. The original body of the issue is below.


Currently, only features available in the v1 version of the compute API are able to be used in Terraform. This is a general issue for support of alpha and beta APIs as well.

(assigning myself but @rileykarson will be working on this)

@rileykarson
Copy link
Collaborator

Given that we've closed out most of the issues in this list, I'm going to close the issue. There are a few issues left outstanding;

@davidquarles
Copy link
Contributor

@rileykarson Forgive me, I'm new here, but is the container/v1beta1 API an extremely recent addition, or are you saying multi-version support for the GKE API won't be supported? Specifically, I'd like to use/add the NodeTaint field to google_container_node_pool, but I'm imagining multi-version API support is a rather intricate prerequisite.

If multi-version support for the GKE client is desirable, does it merit opening a new/separate issue? Any insight is appreciated. Thanks!

@rileykarson
Copy link
Collaborator

Hi @davidquarles!

We created this issue to track multi-version support for just the compute API, but that had more to do with most/all of the alpha/beta feature requests being against compute at the time, and so that we could consolidate information about supporting multiple versions of those APIs in one place instead of having parts of it live in separate issues.

I would recommend filing an issue against google_container_node_pool to support NodeTaint, and to add a note in the issue body that the feature is only present at v1beta1 and not v1.

You're right that the GKE API will need to have versioned support added! Adding NodeTaint support will be a bit more involved than if it was in v1/v1beta1 was already supported by the container API. That being said, if you have a feature request for anything in GCP that the Google Provider doesn't support, regardless of the implementation details, you should file an issue against it/ 👍 it if it already exists! The team often determines what to work/focus on based on demand in the GitHub issues.

luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
Container cluster support for cluster autoprovisioning.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
Container cluster support for cluster autoprovisioning.
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants