Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate bigquery reservation name match expected format #9609

Open
melinath opened this issue Jul 21, 2021 · 0 comments
Open

Validate bigquery reservation name match expected format #9609

melinath opened this issue Jul 21, 2021 · 0 comments
Labels
Milestone

Comments

@melinath
Copy link
Collaborator

melinath commented Jul 21, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Affected Resource(s)

  • google_bigquery_reservation

Description

Bigquery reservations can only use alphanumeric characters and dashes. If you try to include something else (like an underscore) you will get the following unhelpful error from the API:

{
  "error": {
    "code": 400,
    "message": "Malformed reservation.",
    "status": "INVALID_ARGUMENT"
  }
}

References

@rileykarson rileykarson added this to the Goals milestone Jul 26, 2021
@github-actions github-actions bot added service/bigquery forward/review In review; remove label to forward labels Aug 17, 2023
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Feb 8, 2024
…y_platform_config (hashicorp#9609)

* Reapply "Add client config and permissions to google_identity_platform_config (hashicorp#9417)"

This reverts commit 1c1f4d2844b9708f272601555212700382a78e44.

* Fix diff from API for GCIP client

* Add mfa config to GCIP

* Add multiTenant to google_identity_platform_config

* Add monitoring and request Logging to google_identity_platform_config

* Add test cases

* Extend update test to the new attributes

* Findings from review

* First set of review findings from zli82016

* Fix monitoring permadiff via custom flatten

* Fix client.permissions permadiff via custom flatten

* Fix mfa.state permadiff

* Adapt tests to latest changes

* Ignore only outputs for the import verify

[upstream:6029bee2dcd6180a177d33d3b96d4ae3967cc957]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Feb 8, 2024
…y_platform_config (#9609) (#17225)

* Reapply "Add client config and permissions to google_identity_platform_config (#9417)"

This reverts commit 1c1f4d2844b9708f272601555212700382a78e44.

* Fix diff from API for GCIP client

* Add mfa config to GCIP

* Add multiTenant to google_identity_platform_config

* Add monitoring and request Logging to google_identity_platform_config

* Add test cases

* Extend update test to the new attributes

* Findings from review

* First set of review findings from zli82016

* Fix monitoring permadiff via custom flatten

* Fix client.permissions permadiff via custom flatten

* Fix mfa.state permadiff

* Adapt tests to latest changes

* Ignore only outputs for the import verify

[upstream:6029bee2dcd6180a177d33d3b96d4ae3967cc957]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants