Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove google_project_service from state if not found #10045

Conversation

modular-magician
Copy link
Collaborator

Fixes #9841

This PR reverses the change introduced in the sdkv2 upgrade: https://github.com/hashicorp/terraform-provider-google/blame/d1014fe3b47d377db9a6eee9cfa9cbb0412c18e2/google/resource_google_project_service.go#L190

If a service was disabled outside of TF, the previous change showed a permanent error and would not let users re-enable the service until it was removed from state and added back to the config.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

serviceusage: fixed an issue in `google_project_service` where users could not reenable services that were disabled outside of Terraform.

Derived from GoogleCloudPlatform/magic-modules#5184

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 881dcc1 into hashicorp:master Sep 9, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_project_service fails if service is disabled outside of terraform
1 participant