Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in google_monitoring_uptime_check_config #10195

Closed
wants to merge 1 commit into from

Conversation

rwblokzijl
Copy link

Resolves #10106

@megan07
Copy link
Contributor

megan07 commented Oct 4, 2021

Hi @rwblokzijl ! Thanks for this PR! This code is actually generated, so if you'd like to change it upstream, you can fix it here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/monitoring/api.yaml#L1719 (it will fix both the validation and the documentation). Let me know if you don't have time for this fix, and I can make it as well. Thanks!

@rwblokzijl
Copy link
Author

Hi, thanks for the response. I will make the PR :)

@rwblokzijl
Copy link
Author

@megan07
Copy link
Contributor

megan07 commented Oct 5, 2021

Thank you!

@megan07 megan07 closed this Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating resource google_monitoring_uptime_check_config with matcher NON_MATCHES_REGEX
2 participants