Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove username and password from master_auth #10441

Conversation

modular-magician
Copy link
Collaborator

Fixes #8032

Removes basic auth from container cluster. Revives one of the tests removed here: https://github.com/hashicorp/terraform-provider-google-beta/pull/3462/files#diff-bd126349706a4e5427118dc65de0dd5ec0cb74bdf11c6ef5cf967d3a2f3244b6L2662

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: removed `master_auth.username` and `master_auth.password` from `google_container_cluster`
container: made `master_auth.client_certificate_config` required

Derived from GoogleCloudPlatform/magic-modules#5372

* Remove `username` and `password` from `master_auth`

* Add client_certificate_required note

* Update mmv1/third_party/terraform/website/docs/guides/version_4_upgrade.html.markdown

Co-authored-by: Riley Karson <rileykarson@google.com>

* Remove bad merge

Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sam Levenick <slevenick@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c1f9917 into hashicorp:master Oct 29, 2021
brianpham added a commit to brianpham/terraform-google-gke that referenced this pull request Nov 10, 2021
* Add variable for enabled_shieled_nodes
  hashicorp/terraform-provider-google#10403
* Add required client_certificate_config and remove username and password from master_auth
  hashicorp/terraform-provider-google#10441
* Update workload_identity_config to use workload pool instead of
  identity_namespace hashicorp/terraform-provider-google#10410
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove master_auth fields from google_container_cluster resource
1 participant