Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data_source_google_service_account_jwt #12107

Conversation

modular-magician
Copy link
Collaborator

Closes #6686.

This PR adds a google_service_account_jwt data source, similar to the google_service_account_id_token data source. The difference between this and the id_token resource is that the jwt data source can produce an arbitrary JWT, e.g. with a custom sub field, etc.

We're interested in this in order to use our existing Google Cloud credentials to authenticate with other terraform providers that can trust JWTs signed by Google. The linked issue is for Vault, which is not our use-case, but would make sense as well.

Note: I've contributed to terraform-provider-google before, but this is my first time contributing to magic-modules! It definitely feels a little trickier, so let me know if you'd like anything else from me. I would like to add tests to this, but I wanted to at least get a temperature check on the PR before investing more time in it.


If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_service_account_jwt`

Derived from GoogleCloudPlatform/magic-modules#6239

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 14c9d11 into hashicorp:main Jul 15, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a sign JWT resource
1 participant