Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for point_in_time_recovery_enabled flag in mssql instances #13454

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Adding support for point_in_time_recovery_enabled flag in mssql instances #13454

merged 1 commit into from
Jan 11, 2023

Conversation

modular-magician
Copy link
Collaborator

This PR is to fix #13151

Bugaizer ticket : b/261459520

Updated the validation function to allow the setting of point_in_time_recovery_enabled flag for mssql instance, since the API supports it now. Updated the documentation as well.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
sql: Updated the ability to set `point_in_time_recovery_enabled` flag for `SQLSERVER` instance, since the API supports it now.

Derived from GoogleCloudPlatform/magic-modules#7096

@modular-magician
Adding support for point_in_time_recovery_enabled flag in mssql ins…
57ad816 
…tances (hashicorp#7096)

* Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types.

* Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT

* Updated the validation function to allow the setting of  flag for mssql instance, since the API supports it now. Updated documntation as well.

* Updated the validation function to allow the setting of  flag for mssql instance, since the API supports it now. Updated documntation as well.

* Added test function for checking support for point_in_time_recovery_enabled flag in Sql Server.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 5a049d1 into hashicorp:main Jan 11, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

point_in_time_recovery_enabled for mssql
1 participant
@modular-magician