Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list implementation in google_dns_keys data source #14418

Conversation

modular-magician
Copy link
Collaborator

Closes #14298

google_dns_keys was recently migrated to the plugin framework. Currently the Google provider is muxed and uses protocol 5.

Computed blocks have issues when protocol 5 is in use, which result in the problem seen in #14298

In this PR I

  1. change the DNS keys data source to follow the recommended approach for avoiding this issue
  2. update acceptance tests to access these attributes, showing that these code changes fix the issue

Useful links:


If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dns: fixed bug in `google_dns_keys` data source where list attributes could not be used at plan-time

Derived from GoogleCloudPlatform/magic-modules#7748

…p#7748)

* Change computed blocks fields to `schema.ListAttribute`

This is required to fix plan-time issues like : hashicorp#14298

* Update acceptance tests to check computed blocks are accessible at plan time

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 72b59af into hashicorp:main Apr 25, 2023
4 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source google_dns_keys broken in > version 4.59
1 participant