Fix "SSL Mode and Require Connectors Support for AlloyDB (#9064)" to be backwards compatible #16202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" to be backwards compatible (hashicorp#9195) * support to create instance with ssl mode and require connectors, with acceptance tests * removed client_connection_config in basic instance example, and cleaned up the code a little bit * attempts to set the default ssl mode in the custom code * able to set default value during instance creation and addressing some comments * trying to fix updating ssl mode * fixed updating the instance with ssl mode * cleaning up code and fixing acceptance tests * Fixing spacing issues in instance.yaml * fixing spacing issues again in instance.yaml * fixing formatting in unit test * fixing the acceptance tests for other alloydb resources by explicitly adding the clientconnectionconfig * fixing spacing and removing commented out imports * commenting out createInstanceWithMandatoryFields and createPrimaryAndReadPoolInstance tests because they're failing due to an unrelated service networking issue * fix tests failing due to missing client_connection_config * removing service networking resources from tests since there's a bug in service networking * fix breaking change that causes a permadiff in terraform on update * uncomment out the TestAccAlloydbInstance_createPrimaryAndReadPoolInstance and TestAccAlloydbInstance_createInstanceWithMandatoryFields tests * remove private_ip_alloc from client connection config tests * use BootstrapSharedServiceNetworkingConnection in tests instead of BootstrapSharedTestNetwork in tests * add back in custom code * remove commented out code * fix formatting * match network name to be the same format as the other acceptance tests in the file * change network names in test [upstream:dcd92717bf49490c8f7463cb98217ebdaba429e6] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes commit GoogleCloudPlatform/magic-modules@5c05541 which introduced a backward incompatible change (permadiff) that will break all existing configurations. This PR fixes the permadiff by adding
default_from_apitoclientConnectionConfig.sslConfig.sslMode,clientConnectionConfig.sslConfig, andclientConnectionConfig. So now when the default value forclientConnectionConfig.sslConfig.sslModeis applied during create and update, the terraform state recognizes that it is there. Therefore, if the user doesn't specify this field when they create it and upon update continues to leave it unspecified, terraform recognizes that there is no change.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9195