Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_instance_on_destroy option to per-compute instance config resources #16729

Commits on Dec 7, 2023

  1. Add remove_instance_on_destroy option to per-compute instance config …

    …resources (hashicorp#9588)
    
    It's a bit counterintuitive that creating a per-instance config in an IGM
    spins up an instance but destroying it leaves the instance behind.
    
    Also fixed a bug related to the operation to detach the disk from the
    instance failing due to the instance having been deleted. Other than
    the tests for the new per-instance config behavior, I was unable to
    devise an isolated test to trigger this issue.
    
    Fixes hashicorp#9042 & hashicorp#16621.
    [upstream:4153866aaf018b769837b565a1088095fb25ae61]
    
    Signed-off-by: Modular Magician <magic-modules@google.com>
    modular-magician committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f04f398 View commit details
    Browse the repository at this point in the history