Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network fwp #16837

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)

change from DCL to MMv1 for `google_network_firewall_policy` and `google_region_network_firewall_policy` (no note?)

Derived from GoogleCloudPlatform/magic-modules#9345

* Add test fwp conversion

* Added two resources, test

* Remove tpgtools fwp

* Add examples

* Rework legacy long form

* Compile problem

* Fix bad change

* Rework resource.erb for project long form

* Make fmt tests

* Fix tests

* Remove beta as well

* Remove change to utils.go

* Add back shorten to special cases in utils
[upstream:c4a1a5e5f30f185a9b35ed346cc1a296448f9193]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f6dc844 into hashicorp:main Dec 19, 2023
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant