Fix Spanner update when adding/removing autoscaling config #17033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#9814) * Add reproducer test for error. Creating a Spanner instance without auto-scaling and then updating it to add auto-scaling should work, but currently doesn't. * Fix `fieldMask` for spanner updates when enabling/disable autoscaling. When adding/removing auto-scaling config wholesale, the API expects only the top-level `autoscalingConfig` key to be listed in the `fieldMask`. Listing sub-fields of the autoscaling config causes an error. * Add tests for dropping auto-scaling. Not sure if this was broken before, but makes sense to me that we should test in both directions. * Apply review feedback * Fix indentation in template * Rename test instances to match expected pattern * Consolidate tests * Fix name-too-long errors [upstream:8f488115df8493669aae88a65b80a2fcb31d7557] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16983
When adding/removing
autoscaling_configin its entirety, set the top-levelautoscalingConfigconfig in the update request'sfieldMask.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9814