Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource_bigquery_dataset ID validation #17449

Conversation

modular-magician
Copy link
Collaborator

Fixes #12284.

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed dataset ID validation

Derived from GoogleCloudPlatform/magic-modules#10027

* fix resource_bigquery_dataset ID validation

* skip the new validation tests for VCR

* update dataset IDs to be valid in terraform-google-conversion example files

* update more dataset IDs in the CAI files

[upstream:01aba8f193c130c5a3b64d03c1687d81543c8bac]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 519615c into hashicorp:main Feb 28, 2024
2 checks passed
SarahFrench pushed a commit that referenced this pull request Mar 1, 2024
* fix resource_bigquery_dataset ID validation

* skip the new validation tests for VCR

* update dataset IDs to be valid in terraform-google-conversion example files

* update more dataset IDs in the CAI files

[upstream:01aba8f193c130c5a3b64d03c1687d81543c8bac]

Signed-off-by: Modular Magician <magic-modules@google.com>
Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate BigQuery naming requirements before apply
1 participant