Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for string --> object map for DCL resources #17483

Merged
merged 1 commit into from Mar 4, 2024
Merged

Add support for string --> object map for DCL resources #17483

merged 1 commit into from Mar 4, 2024

Conversation

modular-magician
Copy link
Collaborator

Fixes: #16777

Tests for gkehub pass in CI

This adds an override for these maps that specifies the key name and must be present for these fields to work.

Release Note Template for Downstream PRs (will be copied)

gkehub: added support for `policycontroller.policy_controller_hub_config.policy_content.bundles` and 
`policycontroller.policy_controller_hub_config.deployment_configs` fields to `google_gke_hub_feature_membership`

Derived from GoogleCloudPlatform/magic-modules#10039

@modular-magician
Add support for string --> object map for DCL resources (hashicorp#10039
f54c9f7 
)

* Add support for string --> object map for DCL resources

* Fix whitespace in template

* Add test, need updated DCL to work

* Add override for key name

* Both overrides

* Update docs, prepend key for maps

* Update bundle descriptions

* Comment update

[upstream:3ccc673c9b2202948591b546ae21658ea4f19d8a]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b05aedf into hashicorp:main Mar 4, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tpgtools support for object-valued maps
1 participant
@modular-magician