Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms): certificate chain type to array of strings #17486

Conversation

modular-magician
Copy link
Collaborator

The response type for KeyOperationAttestation CertificateChains is an array of strings. This is also what documentation says. https://cloud.google.com/kms/docs/reference/rest/v1/KeyOperationAttestation#certificatechains

However the provider spec for that property lists them as strings, so terraform will panic whenever a key version is created with HSM that uses these certificates as the types are mismatched. This PR fixes this so the type is an array of strings, as well as adding an AccTest for HSM key version

Fixes #13924

Release Note Template for Downstream PRs (will be copied)

kms: fixed issue where `google_kms_crypto_key_version.attestation.cert_chains` properties were incorrectly set to type string

Derived from GoogleCloudPlatform/magic-modules#9582

[upstream:216fffd274b08af2e3f718d3d8aeb8cb6410b420]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c368e09 into hashicorp:main Mar 4, 2024
4 checks passed
Copy link

github-actions bot commented Apr 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading CryptoKeyVersion - provider defined wrong type vs GCP API response
1 participant