Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_firebase_android_app should be replaced when package_name changes #17585

Conversation

modular-magician
Copy link
Collaborator

This is already the behavior in the API. It was forgotten in the initial PR. However, it's not a common operation for an app to change the package_name mid-way, so it probably has little real impact.

Release Note Template for Downstream PRs (will be copied)

firebase: made the `google_firebase_android_app` resource's `package_name` field required and immutable. This prevents API errors encountered by users who attempted to update or leave that field unset in their configurations.

Derived from GoogleCloudPlatform/magic-modules#10194

[upstream:1e3a728a0e161678338b385ee04d4a92b4603c57]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 667a4c7 into hashicorp:main Mar 14, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant