Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reviewer lottery GitHub action, update reviewer list #18157

Merged
merged 1 commit into from
May 16, 2024

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented May 16, 2024

uesteibar/reviewer-lottery doesn't support Node 20 and seems under-maintained, whereas kentaro-m/auto-assign-action uses Node 20: kentaro-m/auto-assign-action@6dcb652

Making this change will help us to address Node 16's deprecation in GitHub

Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@SarahFrench SarahFrench marked this pull request as ready for review May 16, 2024 11:47
@github-actions github-actions bot requested a review from rileykarson May 16, 2024 11:47
@SarahFrench SarahFrench removed the request for review from rileykarson May 16, 2024 11:47
@SarahFrench SarahFrench marked this pull request as draft May 16, 2024 11:49
@SarahFrench SarahFrench marked this pull request as ready for review May 16, 2024 11:49
@github-actions github-actions bot requested a review from ScottSuarez May 16, 2024 11:49
@SarahFrench SarahFrench requested review from rileykarson and removed request for ScottSuarez May 16, 2024 11:51
@SarahFrench
Copy link
Member Author

Thanks, I'm going to test this GHA by opening a few PRs after merging this. I did some testing in a personal repo but there's limitations to that (like not being able to review your own PR).

@SarahFrench SarahFrench merged commit 0bca798 into main May 16, 2024
2 checks passed
@SarahFrench
Copy link
Member Author

Tested here, look ok to me: #18162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants