Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused pgp example #5156

Closed
wants to merge 1 commit into from
Closed

remove unused pgp example #5156

wants to merge 1 commit into from

Conversation

tonglil
Copy link
Contributor

@tonglil tonglil commented Dec 12, 2019

No description provided.

@ghost ghost added the size/xs label Dec 12, 2019
@ghost ghost requested review from paddycarver December 12, 2019 17:55
@ghost ghost added the documentation label Dec 12, 2019

resource "google_service_account_key" "mykey" {
service_account_id = google_service_account.myaccount.name
public_key_type = "TYPE_X509_PEM_FILE"
Copy link
Contributor

@pradeepbhadani pradeepbhadani Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public_key_type is a valid input. Ref: https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_google_service_account_key.go#L45

Could you please provide more info on why it's termed as unused ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this snippet is identical to the first snippet? pgp encryption is no longer supported by terraform.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh .. thanks for the info.

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I'll get it upstreamed and merged.

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@tonglil tonglil deleted the patch-1 branch April 14, 2020 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants