Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry requests without GetBody #5977

Conversation

modular-magician
Copy link
Collaborator

Now, if a request doesn't have GetBody (to copy the request), the request is treated as nonretryable and just sent once as is.

Fixes #5970

Release Note Template for Downstream PRs (will be copied)

provider: Fixed an error with resources failing to upload large files (e.g. with `google_storage_bucket_object`) during retried requests

Derived from GoogleCloudPlatform/magic-modules#3299

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/m label Mar 25, 2020
@modular-magician modular-magician merged commit d44a9a5 into hashicorp:master Mar 25, 2020
danawillow pushed a commit that referenced this pull request Mar 25, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to upload google_storage_bucket_objects larger than ~16MiB (16777215 bytes)
1 participant