Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with useful role to access secret #6739

Merged
merged 1 commit into from Jul 7, 2020

Conversation

bodegus
Copy link
Contributor

@bodegus bodegus commented Jul 5, 2020

I spent an hour trying to figure out why my function did not have permission. I suggest updating the docs so that the example allows you to read the secret

I spent an hour trying to figure out why my function did not have permission.  I suggest updating the docs so that the example allows you to read the secret
@ghost ghost added the size/xs label Jul 5, 2020
@ghost ghost requested a review from nat-henderson July 5, 2020 20:01
@ghost ghost added the documentation label Jul 5, 2020
@nat-henderson
Copy link
Contributor

Thanks! You're right, that's better. I'll mirror this change into our upstream repository, github.com/googlecloudplatform/magic-modules.

nat-henderson added a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Jul 7, 2020
nat-henderson added a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Jul 7, 2020
@nat-henderson nat-henderson merged commit 47fb997 into hashicorp:master Jul 7, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Jul 7, 2020
Upstream hashicorp#6739.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this pull request Jul 7, 2020
Upstream #6739.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Jul 7, 2020
Upstream hashicorp/terraform-provider-google#6739.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request Jul 7, 2020
Upstream hashicorp/terraform-provider-google#6739.

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants