Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored info #7145

Conversation

modular-magician
Copy link
Collaborator

Add support for DLP stored info type. This has a little more complex GET functionality as the API stores previous versions of the info type. I made name not user-settable, and only ever retrieve the current version of the stored info type.

Includes a little refactoring on previous DLP resources

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_data_loss_prevention_stored_info_type

Derived from GoogleCloudPlatform/magic-modules#3922

* Add stored info

* Finish stored info, fix shared import

* Add tests for dictionary, large custom dictionary, txt fixture, async on create for custom dictionary pending status

* Add force destroy to bucket

* Copy/paste errors

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xxl label Aug 28, 2020
@modular-magician modular-magician merged commit 3f1ad63 into hashicorp:master Aug 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant