Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compute_instance] - Allow updating of network and subnetwork properties #7358

Conversation

modular-magician
Copy link
Collaborator

Allow updating of network and subnetwork properties on resource_compute_instance.
Some issues of 7118 are fixed. Still need to add support for updating network_ip during subnetwork change. This would require utilizing a customized diff.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for updating `network_interface.[d].network` and `network_interface.[d].subnetwork` properties on `google_compute_instance`.

Derived from GoogleCloudPlatform/magic-modules#4011

…ies (hashicorp#4011)

* [compute_instance] - Allow updating of network and subnetwork properties

* fix spelling error

* resolve comments

* switch to use id over self link

* remove unused var

* resolve comments

* take into account fingerprint refresh before update call.

* spelling fix

* Update third_party/terraform/resources/resource_compute_instance.go.erb

typo correction

Co-authored-by: Cameron Thornton <camthornton@google.com>

* Update third_party/terraform/resources/resource_compute_instance.go.erb

typo correction

Co-authored-by: Cameron Thornton <camthornton@google.com>

* Add comment explaining subnetwork/network relationship. Changed test name

Co-authored-by: Cameron Thornton <camthornton@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/l labels Sep 25, 2020
@modular-magician modular-magician merged commit 02bc6fd into hashicorp:master Sep 25, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant