Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 7456 spanner database deletion protection #7557

Conversation

modular-magician
Copy link
Collaborator

Fixes #7456.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: added `deletion_protection` field to `google_spanner_database` to make deleting them require an explicit intent.
spanner: `google_spanner_database` resources now cannot be destroyed unless `deletion_protection = false` is set in state for the resource.

Derived from GoogleCloudPlatform/magic-modules#4117

* Added virtual deletion_protection field to spanner along with custom code to prevent deletion

* Made deletion_protection be ignored on ImportStateVerify

* Disabled deletion_protection on various explicitly-created spanner databases in other test resources

* Use GetOkExists instead of GetOk so that boolean virtual fields with a default of true can be set to false and not get overridden

* Added deletion_protection to ImportStateVerifyIgnore for handwritten tests

* Added delete protection test

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Nov 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deletion_protection for google_spanner_database
1 participant