Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promoted (most of) the supported cloud identity resources to GA #7786

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Promoted (most of) the supported cloud identity resources to GA #7786

merged 1 commit into from
Nov 11, 2020

Conversation

modular-magician
Copy link
Collaborator

Resolved #7757.

Notes:

  • Enabled additional_keys and member_key fields, beta-only
  • Removed references to dynamic groups; they are in the API but will require additional work because they require a premium SKU to test. Since they were already not included in the provider, we don't lose anything by fully deleting them.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_identity: promoted `google_cloud_identity_group` to GA

cloud_identity: promoted `google_cloud_identity_group_membership` to GA

cloud_identity: promoted data source `google_cloud_identity_groups` to GA

cloud_identity: promoted data source `google_cloud_identity_group_memberships` to GA

Derived from GoogleCloudPlatform/magic-modules#4211

@modular-magician
Promoted (most of) the supported cloud identity resources to GA (hash…
342ff4c 
…icorp#4211)

* Promoted supported cloud identity APIs to GA

* Removed trailing references to cloudidentity v1beta1 api

* cloud identity group membership member_key is still in beta

* Use v1beta1 cloudidentity sdk in beta

* Skip tests relying on cust_id and identity_user if not set

* Removed trailing references to beta provider in data source tests

* Corrected trailing references to google-beta provider in cloud identity test code

* Moved tests involving member_key to beta-only

* Removed duplicate func in beta: testAccCheckCloudIdentityGroupMembershipDestroyProducer

* Enabled / marked remaining beta fields

* Removed dynamic groups because they require a premium SKU

* Removed references to additionalGroupKeys

* Fixed test file imports

* Corrected Cloud Identity GA version to use GA api

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/xxl labels Nov 11, 2020
@modular-magician modular-magician merged commit ed6dd27 into hashicorp:master Nov 11, 2020
@ghost
Copy link

ghost commented Dec 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xxl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cloud identity apis to ga
1 participant
@modular-magician