Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream new restore policy #7906

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Upstream new restore policy #7906

merged 1 commit into from
Nov 30, 2020

Conversation

modular-magician
Copy link
Collaborator

Upstreams #7768

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

project: added new restore_policy `REVERT_AND_IGNORE_FAILURE` to `google_project_default_service_accounts`

Derived from GoogleCloudPlatform/magic-modules#4267

@modular-magician @thiagonache
Upstream new restore policy (hashicorp#4267)
9a12193 
* Adds REVERT_AND_IGNORE description and prefix on log lines with printf

* Fixes typo

* Adds new restore policy REVERT_AND_IGNORE_FAILURE in order to ignore errors returned on the revert during the resource destroy

* Adds new test for new restore policy. This function should not check revert because the policy says to ignore. I have injected an error on the undelete function to simulate API error and it worked as expected. Worth to mention that on day to day it is just testing it overall behavior when the restore_policy is REVERT_AND_IGNORE_FAILURE

* Reordering error handling code, no functional changes

Co-authored-by: Thiago Carvalho <thiagonbcarvalho@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/s labels Nov 30, 2020
@modular-magician modular-magician merged commit 22d296a into hashicorp:master Nov 30, 2020
@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician