Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud_identity): google_cloud_identity_group_membership import/update #8867

Conversation

modular-magician
Copy link
Collaborator

Fixed bugs in google_cloud_identity_group_membership:

  • 36ef27a3d6e1c4de22ac29c91b55b0e9b88036ac: Previously, terraform import does not set group attribute, which is marked as "ForceNew", so it always show recreation plan after import. Fixed this by filling it on post_import
  • fcc008fc55210b00caaa86de2f41bf717c4a6bbb: Previously, update functions is not properly implemented, so it always returns 404. Fix this by implementing update function to call modifyMembershipRoles method. Fix Updating a google_cloud_identity_group_membership to remove a role fails with an error #7616

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    • 👉 I can't run the exact acctests because I don't have a permission to create groups in my organization. However, I ran them with hardcoding an existing group ID and confirmed they passed.
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_identity: fix google_cloud_identity_group_membership import/update

Derived from GoogleCloudPlatform/magic-modules#4658

…date (hashicorp#4658)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label Apr 7, 2021
@modular-magician modular-magician merged commit 1413a2d into hashicorp:master Apr 7, 2021
@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a google_cloud_identity_group_membership to remove a role fails with an error
1 participant