Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_bucket_object: added holds #9403

Closed
wants to merge 1 commit into from
Closed

storage_bucket_object: added holds #9403

wants to merge 1 commit into from

Conversation

jaceq
Copy link
Contributor

@jaceq jaceq commented Jun 21, 2021

Resolving: #6022

Added temporary and event based hold attributes to bucket object.

@jaceq
Copy link
Contributor Author

jaceq commented Jun 22, 2021

Hi @rileykarson could someone be assigned for a review here? Seems that 'reviewer lottery' doesn't work really

@rileykarson
Copy link
Collaborator

Assign @ScottSuarez for review

@megan07: It seems like a PR needs to pass unit tests to add a reviewer, can we reverse the order so we assign a reviewer first?

@ScottSuarez
Copy link
Collaborator

This looks good to me :)

@jaceq would you mind making these changes to our upstream repository..
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/resources/resource_storage_bucket_object.go
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/tests/resource_storage_bucket_object_test.go

and making a pull request there ? I can upstream it a bit later if not, no stress.

@jaceq
Copy link
Contributor Author

jaceq commented Jun 25, 2021

@ScottSuarez
Copy link
Collaborator

superseded by GoogleCloudPlatform/magic-modules#4921

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants