Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles 404 on create of user resource #287

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Conversation

cstadach
Copy link
Contributor

issue #286

@megan07
Copy link
Contributor

megan07 commented May 11, 2022

@cstadach Thank you! And sorry for my delay on this. Is user the only resource that this seems to be an issue with? What are your thoughts on making this more general and adding it to the other eventual consistency checks as well? If you're able to, it'd be nice to update for that.

@cstadach
Copy link
Contributor Author

@megan07: good point. I would assume this is a general issue with this google API.
I'll get back to you about that

@cstadach
Copy link
Contributor Author

Hi @megan07,
I applied the changes to all ressources which seem to be eventually consistent.

Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstadach Thank you for updating each of those resources! I noticed a minor issue in one of the unit tests (see comment) which should be a quick fix. Could you please address that, or if you don't have time I'm happy to merge this PR and fix it after- let me know what you prefer.

internal/provider/retry_predicates_test.go Outdated Show resolved Hide resolved
@SarahFrench
Copy link
Member

Thank you! Lets get this merged :shipit:

@SarahFrench SarahFrench merged commit b976055 into hashicorp:main Jun 1, 2022
@vkbytes
Copy link

vkbytes commented Jun 2, 2022

is there going to be a new release with this fix in it. I tried updating and I am at the latest version of the provider.

@megan07
Copy link
Contributor

megan07 commented Jun 2, 2022

Hi @vkbytes, we're aiming to release in the next week or so. Thank you for your patience!

@vkbytes
Copy link

vkbytes commented Jun 2, 2022

You guys are awesome!! I'll try to build it and test it as well!! Thank you

@Luis-3M
Copy link

Luis-3M commented Jun 6, 2022

Awesome guys ! @vkbytes @megan07 when will this be released ?

@ohurvitz
Copy link

I’m also waiting for this. @megan07 Any ETA on the release?

Sent with GitHawk

@mchesler
Copy link

Also blocked by this and would love an update on release ETA @megan07. Thanks @cstadach for implementing this fix!!

@megan07
Copy link
Contributor

megan07 commented Jun 10, 2022

Hi everyone! This has been released! Please let us know if you're seeing any issues with this new release. Thanks for your patience!

@vkbytes
Copy link

vkbytes commented Jun 11, 2022

Just tried creating a user and it went through perfectly...

@santisaez
Copy link

Hi everyone! This has been released! Please let us know if you're seeing any issues with this new release. Thanks for your patience!

@megan07 just tested and the issue no longer happens, @cstadach thanks!

By the way, the ChangeLog says that this version is unreleased:

https://github.com/hashicorp/terraform-provider-googleworkspace/blame/dae45930d91d535bd92374666f2766509d973c01/CHANGELOG.md#L1

@SarahFrench
Copy link
Member

Thanks for the heads up @santisaez! I've just updated the ChangeLog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants