Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add googleworkspace_groups data resource #313

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented May 27, 2022

Description

Fixes #276

This PR adds a plural googleworkspace_groups data resource as requested in the issue above

The listed groups have the same schema as the singular googleworkspace_group data resource.

Also added:

  • Generated documentation + example usage
  • New acceptance test TestAccDataSourceGroups

The new test passes when run locally:

make testacc TESTARGS='-run=TestAccDataSourceGroups'

Screenshot 2022-05-26 at 18 43 29

@SarahFrench SarahFrench requested a review from megan07 May 27, 2022 10:25
@SarahFrench SarahFrench added documentation Improvements or additions to documentation enhancement New feature or request labels May 27, 2022
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SarahFrench SarahFrench merged commit 5d5499d into main May 27, 2022
@SarahFrench SarahFrench deleted the add-groups-data-resource branch May 27, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New datasource googleworkspace_groups
2 participants