Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set access_token via ENV variable #319

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Add ability to set access_token via ENV variable #319

merged 2 commits into from
Jun 6, 2022

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented May 31, 2022 •
edited

Description

Closes #295

Allows the access_token argument to be set via an GOOGLE_OAUTH_ACCESS_TOKEN env variable

I manually tested locally that the ENV can be pulled in to configure the providers auth ok

@SarahFrench SarahFrench marked this pull request as ready for review June 6, 2022 14:39
@SarahFrench SarahFrench added the enhancement New feature or request label Jun 6, 2022
@SarahFrench SarahFrench requested a review from megan07 June 6, 2022 14:50
megan07
megan07 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SarahFrench SarahFrench merged commit 7a29073 into main Jun 6, 2022
@SarahFrench SarahFrench deleted the add-oauth-env-variable branch June 6, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megan07 megan07 megan07 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for GOOGLE_OAUTH_ACCESS_TOKEN env var
2 participants
@SarahFrench @megan07