Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version upgrade tfp work #383

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

andrey-donelli
Copy link
Contributor

@andrey-donelli andrey-donelli commented Aug 29, 2022

πŸ› οΈ Description

Add support for the new major version upgrade configuration.
Original PR
JIRA ticket

🚒 Release Note

Vault: enable changes on mvu configuration  [GH-383]

πŸ—οΈ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestGetValidMajorVersionUpgradeConfig'
=== RUN   TestGetValidMajorVersionUpgradeConfig
--- PASS: TestGetValidMajorVersionUpgradeConfig (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	0.411s

$ make testacc TESTARGS='-run=TestAccVaultCluster'
=== RUN   TestAccVaultCluster
--- PASS: TestAccVaultCluster (3179.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	3180.149s
...

@andrey-donelli andrey-donelli marked this pull request as ready for review August 29, 2022 13:40
@biazmoreira
Copy link

Would love to see a more detailed description and an associated ticket so that I can review this.

@andrey-donelli
Copy link
Contributor Author

Would love to see a more detailed description and an associated ticket so that I can review this.

I added more information on the description and the JIRA ticket, but this is basically enabling MVU config changes on terraform.

@JolisaBrownHashiCorp
Copy link
Contributor

JolisaBrownHashiCorp commented Aug 31, 2022

make testacc TESTARGS='-run=TestAccVaultCluster'
==> Checking that code complies with gofmt requirements...
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/clients 0.493s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/consul 1.314s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/input 1.426s [no tests to run]
=== RUN TestAccVaultCluster
--- PASS: TestAccVaultCluster (3904.52s)
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/provider 3905.025s

The changes passed the Vault acceptance tests as well and look good to go! πŸŽ‰πŸŽ‰

@JolisaBrownHashiCorp JolisaBrownHashiCorp merged commit af1c7ca into main Aug 31, 2022
@JolisaBrownHashiCorp JolisaBrownHashiCorp deleted the HVT-1629-Major-Version-TFP-Work branch August 31, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants