Added doc updates to take into account project level service principals #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xargs-P
changed the title
docs/guides/auth.md
Outdated
| @@ -38,6 +40,8 @@ Save the client ID and secret as the environment variables HCP_CLIENT_ID and HCP | |||
|
|
|||
| Or, configure the provider with the client ID and secret by copy-pasting the values directly into provider config. | |||
|
|
|||
| -> **Warning:** Hard-coded credentials are not recommended in Terraform configuration outside of local testing and can risks secret exposure if committed to a code repository. | |||
There was a problem hiding this comment.
👀 Small thing I noticed: I think you may have intended to put can risk or risks here 😄
jesdavpet
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Doc update to take into account Project level service principals